impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode
Date Mon, 16 May 2016 21:07:44 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode
......................................................................


Patch Set 8:

The new version claws back a significant chunk of the regression (mainly via the hash_tbls_
cache):
            Report Generated on 2016-05-16
            Run Description: "Base: 89ee8d85c6e4e1a8d5522c34df5a0ebfeb6491f2 vs Ref: 9691d2b53ef330e3962b453681e4916b4d92af95"

            Cluster Name: UNKNOWN
            Lab Run Info: UNKNOWN
            Impala Version:          impalad version 2.6.0-cdh5-INTERNAL RELEASE ()
            Baseline Impala Version: impalad version 2.6.0-cdh5-INTERNAL RELEASE ()

            +--------------------+-----------------------+---------+------------+------------+----------------+
            | Workload           | File Format           | Avg (s) | Delta(Avg) | GeoMean(s)
| Delta(GeoMean) |
            +--------------------+-----------------------+---------+------------+------------+----------------+
            | TARGETED-PERF(_20) | parquet / none / none | 13.27   | -14.63%    | 7.59   
   | -9.16%         |
            +--------------------+-----------------------+---------+------------+------------+----------------+

            +--------------------+---------------------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
            | Workload           | Query                                 | File Format   
       | Avg(s) | Base Avg(s) | Delta(Avg) | StdDev(%) | Base StdDev(%) | Num Clients | Iters
|
            +--------------------+---------------------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+
            | TARGETED-PERF(_20) | primitive_groupby_decimal_lowndv.test | parquet / none
/ none | 2.11   | 2.02        |   +4.71%   |   1.36%   |   2.35%        | 1           | 10
   |
            | TARGETED-PERF(_20) | primitive_groupby_bigint_lowndv       | parquet / none
/ none | 2.12   | 2.07        |   +2.32%   |   1.77%   |   4.02%        | 1           | 10
   |
            | TARGETED-PERF(_20) | primitive_groupby_decimal_highndv     | parquet / none
/ none | 14.90  | 16.50       |   -9.65%   |   6.41%   |   0.70%        | 1           | 10
   |
            | TARGETED-PERF(_20) | primitive_groupby_bigint_pk           | parquet / none
/ none | 36.96  | 43.58       |   -15.17%  |   7.43%   |   0.53%        | 1           | 10
   |
            | TARGETED-PERF(_20) | primitive_groupby_bigint_highndv      | parquet / none
/ none | 10.27  | 13.58       | I -24.38%  |   1.80%   |   1.72%        | 1           | 10
   |
            +--------------------+---------------------------------------+-----------------------+--------+-------------+------------+-----------+----------------+-------------+-------+

            (I) Improvement: TARGETED-PERF(_20) primitive_groupby_bigint_highndv [parquet
/ none / none] (13.58s -> 10.27s [-24.38%])
            +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+
            | Operator     | % of Query | Avg      | Base Avg | Delta(Avg) | StdDev(%) | Max
     | Base Max | Delta(Max) | #Hosts | #Rows   | Est #Rows |
            +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+
            | 03:AGGREGATE | 31.17%     | 3.14s    | 3.61s    | -13.02%    |   2.25%   | 3.31s
   | 3.73s    | -11.43%    | 1      | 0       | 2.95M     |
            | 02:EXCHANGE  | 2.39%      | 241.38ms | 254.61ms | -5.20%     |   2.05%   | 251.16ms
| 265.85ms | -5.53%     | 1      | 30.00M  | 29.49M    |
            | 01:AGGREGATE | 64.14%     | 6.47s    | 9.64s    | -32.89%    |   2.58%   | 6.68s
   | 9.83s    | -32.07%    | 1      | 30.00M  | 29.49M    |
            | 00:SCAN HDFS | 2.30%      | 231.76ms | 229.50ms | +0.99%     |   3.87%   | 256.42ms
| 247.23ms | +3.72%     | 1      | 119.99M | 119.99M   |
            +--------------+------------+----------+----------+------------+-----------+----------+----------+------------+--------+---------+-----------+

            Significant perf change detected

-- 
To view, visit http://gerrit.cloudera.org:8080/3070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message