impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) IMPALA-3286: prefetching for PartitionedAggregationNode
Date Mon, 16 May 2016 20:58:37 GMT
Tim Armstrong has uploaded a new patch set (#8).

Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode

IMPALA-3286: prefetching for PartitionedAggregationNode

This patch builds on top of the prefetching infrastructure to add
prefetching to PartitionedAggregationNode. Input batches are evaluated
in prefetch groups and hash table buckets are prefetched if the
prefetch_mode query option is set to HT_BUCKET.

We avoid some pointer indirections on the critical path by caching hash
tables in a 'hash_tbls_' array.

There is also a bit of cleanup to directly instantiate the templated
ProcessBatch() method to remove the ProcessBatch_true() and
ProcessBatch_false() hack, and also to separate out
ProcessBatchNoGrouping() so that it doesn't have to have the same
argument list as ProcessBatch().

TODO: once we finish the PHJ::ProcessProbeBatch() patch I
will do a final pass and make sure that this is consistent.

Co-author: Michael Ho <>

Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b
M be/src/codegen/
M be/src/exec/
M be/src/exec/
M be/src/exec/
M be/src/exec/partitioned-aggregation-node.h
5 files changed, 203 insertions(+), 109 deletions(-)

  git pull ssh:// refs/changes/70/3070/8
To view, visit
To unsubscribe, visit

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b
Gerrit-PatchSet: 8
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Michael Ho <>
Gerrit-Reviewer: Mostafa Mokhtar <>
Gerrit-Reviewer: Tim Armstrong <>

View raw message