impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sailesh Mukil (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3532: S3: test_truncate_cleans_hdfs_files fails because we skip INSERT staging
Date Fri, 13 May 2016 22:28:40 GMT
Hello Michael Brown,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/3049

to look at the new patch set (#4).

Change subject: IMPALA-3532: S3: test_truncate_cleans_hdfs_files fails because we skip INSERT
staging
......................................................................

IMPALA-3532: S3: test_truncate_cleans_hdfs_files fails because we skip INSERT staging

On the introduction of IMPALA-3452, we defaulted to skipping the
INSERT staging for S3. test_truncate_cleans_hdfs_files assumes that
it will always see the _impala_insert_staging folder but we will not
see that on S3 runs.

This patch deletes the staging folder if it exists and continues the
test without taking into account the staging folder.

Change-Id: I3580f03690e29fe99f441b26bc9baa4c0964d79c
---
M tests/metadata/test_ddl.py
1 file changed, 26 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/49/3049/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3580f03690e29fe99f441b26bc9baa4c0964d79c
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message