impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3489: Add script to extract breakpad symbols from binaries
Date Fri, 13 May 2016 00:40:09 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

Thanks for addressing all my comments. I think 1 got missed, but otherwise, it looks good.

http://gerrit.cloudera.org:8080/#/c/2961/5/bin/dump_breakpad_symbols.py
File bin/dump_breakpad_symbols.py:

Line 227:   tmp_fd, tmp_file = tempfile.mkstemp(dir=out_dir, suffix='.sym')
This file never gets closed.


-- 
To view, visit http://gerrit.cloudera.org:8080/2961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message