impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Taras Bobrovytsky (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3232: Allow not-exists uncorrelated subqueries
Date Thu, 12 May 2016 18:15:09 GMT
Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-3232: Allow not-exists uncorrelated subqueries
......................................................................


Patch Set 2:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/2792/2/fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java
File fe/src/main/java/com/cloudera/impala/analysis/StmtRewriter.java:

Line 423: for if uncorrelated
> looks like the sentence is not complete
Done


http://gerrit.cloudera.org:8080/#/c/2792/2/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test
File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test:

Line 717: # Uncorrelated NOT EXISTS with a LIMIT 0 clause
> Did we reject these cases before?
I don't think we have tests for that case (at least not in this file, because it passes when
I run it).


Line 724: ====
> The query in the JIRA is also a nice test case (WITH clause). You may want 
Done


http://gerrit.cloudera.org:8080/#/c/2792/2/testdata/workloads/functional-query/queries/QueryTest/subquery.test
File testdata/workloads/functional-query/queries/QueryTest/subquery.test:

Line 350: that returns an empty set
> The subquery returns rows, so I don't think the description is accurate.
Done


Line 355: order by id
> I don't think this adds anything to this test case, maybe remove it?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I52ae12f116d026190f3a2a7575cda855317d11e8
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message