impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3489: Add script to extract breakpad symbols from binaries
Date Thu, 12 May 2016 13:24:50 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-3489: Add script to extract breakpad symbols from binaries
......................................................................


Patch Set 3:

(2 comments)

Thanks for the review, see PS5.

http://gerrit.cloudera.org:8080/#/c/2961/3/bin/dump_breakpad_symbols.py
File bin/dump_breakpad_symbols.py:

Line 29: Goodle
> Typo
Done


Line 37: #   ./dump_breakpad_symbols -d /tmp/syms -r tmp/impala-2.5.0+cdh5.7.0+0-1.cdh5.7.0.p0.147.el6.x86_64.rpm
-s tmp/impala-debuginfo-2.5.0+cdh5.7.0+0-1.cdh5.7.0.p0.147.el6.x86_64.rpm
> long lines, here and elsewhere in this file.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ee0972efcb50609407b04cd6f4309b244a84861
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message