impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2809: Improved scalar ByteSwap().
Date Thu, 12 May 2016 01:09:56 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-2809: Improved scalar ByteSwap().
......................................................................


Patch Set 1:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/3033/1/be/src/util/bit-util.h
File be/src/util/bit-util.h:

Line 167:   /// Write the swapped bytes into dest. source and dest cannot overlap.
Can we move this into an inline.h file? This header is included essentially everywhere and
it's getting a bit bloated.


Line 168: fixed_len_size
why not 'len'?


Line 177: BitUtil
The BitUtil:: prefix is unnecessary.


Line 264:       default:
The default case is a little weird in that we fall back to a deoptimised implementation for
longer strings. Comment that it's optimised for <= 16 bytes.


Line 265:         uint8_t* d = reinterpret_cast<uint8_t*>(dst);
These casts are redundant now.


-- 
To view, visit http://gerrit.cloudera.org:8080/3033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message