impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3500: GetEffectiveUser() segfault using -enable_rm
Date Wed, 11 May 2016 22:38:32 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3500: GetEffectiveUser() segfault using -enable_rm
......................................................................


IMPALA-3500: GetEffectiveUser() segfault using -enable_rm

A previous change to improve admission control broke Llama
integration. The Coordinator's runtime_state has a partial
TQueryCtx, it doesn't have the TSessionState which is used
by RuntimeState::effective_user(), so calling that in the
SimpleScheduler caused the process to crash.

This is easily fixed by using the TSessionState from the
schedule (which is what the Admission Control code was
doing).

Llama integration is no longer supported, so this was only
tested manually.

Change-Id: Ia04b6aec35ae794d7062fd32104f3964f397f00c
Reviewed-on: http://gerrit.cloudera.org:8080/3016
Reviewed-by: Alex Behm <alex.behm@cloudera.com>
Reviewed-by: Dan Hecht <dhecht@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/scheduling/simple-scheduler.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Internal Jenkins: Verified
  Alex Behm: Looks good to me, but someone else must approve
  Dan Hecht: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/3016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia04b6aec35ae794d7062fd32104f3964f397f00c
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins

Mime
View raw message