impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3490: Add flag to reduce minidump size
Date Wed, 11 May 2016 20:47:08 GMT
Hello Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2990

to look at the new patch set (#5).

Change subject: IMPALA-3490: Add flag to reduce minidump size
......................................................................

IMPALA-3490: Add flag to reduce minidump size

IMPALA-2686 added the breakpad library to all impala daemons, thus enabling them
to write minidump files. This change introduces a flag
'minidump_size_limit_hint_kb', which causes breakpad to reduce the amount of
thread stack memory it includes in a minidump, aiming to reduce the minidump
size during crashes with a lot of threads. Once a minidump is expected to
exceed the configured value, breakpad will include the full stack memory for the
first 20 threads, and afterwards capture only 2KB of stack memory for each
additional thread.

Change-Id: I2f3aa0df51be9f0bf0755fb288702911cdb88052
---
M be/src/common/global-flags.cc
M be/src/util/minidump.cc
M tests/custom_cluster/test_breakpad.py
3 files changed, 63 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/90/2990/5
-- 
To view, visit http://gerrit.cloudera.org:8080/2990
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2f3aa0df51be9f0bf0755fb288702911cdb88052
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>

Mime
View raw message