impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3502: Fix race in the coordinator while updating filter routing table
Date Tue, 10 May 2016 22:58:54 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3502: Fix race in the coordinator while updating filter routing table
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3018/1/be/src/runtime/coordinator.cc
File be/src/runtime/coordinator.cc:

Line 547:     // Populate the runtime filter routing table
Comment that this needs to be done before starting the remote fragments.


Line 563: (has_coordinator_fragment ? 1 : 0)
It would be good to factor this out into first_remote_fragment_idx, or something meaningful.


-- 
To view, visit http://gerrit.cloudera.org:8080/3018
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecc737106fd38aa4af0c72959a577adfb413728d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message