impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3491: Use unique_database fixture in test_recover_partitions.py.
Date Mon, 09 May 2016 18:39:13 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-3491: Use unique_database fixture in test_recover_partitions.py.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3003/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

Line 48:   def __get_fs_location(self, db_name, table_name):
       :     return 'test-warehouse/%s.db/%s/' % (db_name, table_name)
Don't you need to use get_fs_path() here?


Line 79:     assert self.has_value(PART_NAME, result.data) == False
There are a lot of places in this test module that have lines like this: comparison of a Boolean
expression to a Boolean literal. While fixing these up to simply assert the expression (or
assert not the expression) and not compare directly against the literal would make you a good
citizen, it also isn't germane to the patch. It's up to you whether you want to fix them.


-- 
To view, visit http://gerrit.cloudera.org:8080/3003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5be5fa5d20bc6ed5b7830e0ce90201431d6aa008
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message