impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Use unique_database fixture in test_partition_metadata.py
Date Sat, 07 May 2016 05:45:22 GMT
Alex Behm has posted comments on this change.

Change subject: Use unique_database fixture in test_partition_metadata.py
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2962/1/tests/common/impala_test_suite.py
File tests/common/impala_test_suite.py:

Line 492:   def run_stmt_in_hive(self, stmt):
> Since you promoted this, there's an opportunity to kill some redundant code
Good observation. I tried fixing the permanent UDFs test in the same way, but that resulted
in test failures. Apparently beeline and the hive shell behave a little differently and/or
produce different stdout. I tried resolving those issues, but at some point I could not figure
out the problem easily, so I think it's better to leave that out of this patch.

Imo, we should eventually also get rid of beeline and just use a Hive HS2 client.


http://gerrit.cloudera.org:8080/#/c/2962/1/tests/metadata/test_partition_metadata.py
File tests/metadata/test_partition_metadata.py:

Line 51:     table_name = "same_loc_test"
> I don't have a strong opinion either way about this, but I think some prefe
Done


Line 52:     self.client.execute("use %s" % unique_database)
> "use" has a side-effect across tests because of persistent connections. Ide
Agreed. Better to avoid "use". Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/2962
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70d87941fbfc30f41e1c6fcfee8d8c7f16b88831
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message