impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove DDL delegates
Date Sat, 07 May 2016 02:03:30 GMT
Hello Dimitris Tsirogiannis,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2996

to look at the new patch set (#3).

Change subject: Remove DDL delegates
......................................................................

Remove DDL delegates

There was only one functional delegate (for Kudu) the existence of the
other delegate and the use of delegates in general has led to confusion.
The Kudu delegate only exists to provide functionality missing from
Hive. Eventually Hive should have the needed functionality and the Kudu
delegate (renamed in this patch to KuduCatalogOpExecutor) can be removed.

Change-Id: I37f964f8b663fff219aa4eff3e2ef8e89217acf3
---
M fe/src/main/java/com/cloudera/impala/analysis/CreateTableStmt.java
M fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java
M fe/src/main/java/com/cloudera/impala/catalog/Table.java
D fe/src/main/java/com/cloudera/impala/catalog/delegates/DdlDelegate.java
D fe/src/main/java/com/cloudera/impala/catalog/delegates/KuduDdlDelegate.java
D fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java
M fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
A fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java
8 files changed, 273 insertions(+), 400 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/96/2996/3
-- 
To view, visit http://gerrit.cloudera.org:8080/2996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37f964f8b663fff219aa4eff3e2ef8e89217acf3
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>

Mime
View raw message