impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Casey Ching (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Remove DDL delegates
Date Sat, 07 May 2016 01:27:24 GMT
Casey Ching has posted comments on this change.

Change subject: Remove DDL delegates
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/2996/1//COMMIT_MSG
Commit Message:

Line 9: ass
> typo
Ha!


http://gerrit.cloudera.org:8080/#/c/2996/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java:

Line 1144: delegate
> Maybe we should update the comments to not reference the concept of delegat
Done


http://gerrit.cloudera.org:8080/#/c/2996/1/fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java
File fe/src/main/java/com/cloudera/impala/service/KuduCatalogOpExecutor.java:

Line 44: XXX:
> Very insightful comment :)
Woops I left this here to remind myself too...


Line 56: msTable
> nit: the input param is 'msTbl'
Done


Line 124:    * TableNotFoundException is thrown.
> nit: You may also want to mention that an exception is thrown if we fail to
Done


Line 213: KuduClient
> Out of curiosity, does the creation of a kudu client always succeed, even i
Yes, the connection is done lazily on first use.


-- 
To view, visit http://gerrit.cloudera.org:8080/2996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37f964f8b663fff219aa4eff3e2ef8e89217acf3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message