impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mostafa Mokhtar (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism
Date Fri, 06 May 2016 23:29:45 GMT
Mostafa Mokhtar has uploaded a new patch set (#2).

Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism
......................................................................

IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism

On the client side, the wrapping of transports is the opposite of
what it is on the server side:
Client side: TSaslTransport(TBufferedTransport(socket))
Server side: TBufferedTransport(TSaslTransport(socket))

When we write a structure, we end up doing lots of write calls which hit the
TSaslTransport, which does no buffering. So it ends up producing an output
that looks like [0, 0, 0, 1], <one char>, [0, 0, 0, 1], <one char>,
etc. for each individual write call going into it.
These end up buffered so we don't get lots of tiny packets on the send side.
But on the receiver side, we are doing one recv call per Sasl frame.

This patch reorders the wrapping of transports in the thrift client,
so that it matches the order on the thrift server which improves exhange
performance making it within 10% of non-kerberos.

Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9
---
M be/src/rpc/thrift-client.h
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/69/2769/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message