impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3375: Improve TopN performance with a trivial Compare object.
Date Fri, 06 May 2016 22:46:54 GMT
Jim Apple has posted comments on this change.

Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object.
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/2936/3/be/src/util/tuple-row-compare.h
File be/src/util/tuple-row-compare.h:

Line 38: /// ComparatorWrapper takes a reference to an object of type T, rather than copying
that
> update
Done


Line 46:   template <typename X>
> switch this to 'type T' (which ties in with your comment on l29)
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message