impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) Use unique_database fixture in
Date Fri, 06 May 2016 15:51:34 GMT
Alex Behm has posted comments on this change.

Change subject: Use unique_database fixture in

Patch Set 1:

File tests/metadata/

Line 149:         "from functional.alltypes limit 10" % table_name)
> Backslash not needed when a multi-line string literal is within parentheses

Line 153: 
> Why did you remove the REFRESH that existed in the test before?
The previous version of the test computed stats with an external script/client, so a refresh
was needed to pick them up.

Line 158:     self.client.execute("invalidate metadata %s" % table_name)
> Why did you add the invalidate metadata that was not in the test before?
This test is guarding against regression of a bug where the Metastore contains column stats
for a column that used to be a different (incompatible) type, and the failure happens when
loading table metadata, so after changing the column type we force a metadata reload.

Line 168:     self.client.execute("compute stats %s" % table_name)
> Another REFRESH removed after L168 (see L79-80 in the removed file).
Same as above, compute stats is now done via self.client and not an external script.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I88aa77464a95993c018e19a52eeb496d7c3eef08
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Michael Brown <>
Gerrit-HasComments: Yes

View raw message