impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Internal Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3472: hdfs-util-test failing on local FS
Date Thu, 05 May 2016 22:29:07 GMT
Internal Jenkins has submitted this change and it was merged.

Change subject: IMPALA-3472: hdfs-util-test failing on local FS
......................................................................


IMPALA-3472: hdfs-util-test failing on local FS

Our GetFilesystemNameLength() function had a special case for
locations starting with "file:". However, if a scheme had only one
'/' in the scheme delimiter (i.e. ':/' vs '://'), we would return '0'
as the length for that URI.

This is exactly what one of our test cases in hdfs-util-test was
doing. I think it's safe to say we will never get a scheme with only
one following '/' for schemes other than "file:", so I've changed that
testcase.

Change-Id: I0f1232345c62db48575530785c79c0ffe77c2772
Reviewed-on: http://gerrit.cloudera.org:8080/2958
Reviewed-by: Sailesh Mukil <sailesh@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/util/hdfs-util-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Internal Jenkins: Verified
  Sailesh Mukil: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/2958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f1232345c62db48575530785c79c0ffe77c2772
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Sailesh Mukil <sailesh@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Sailesh Mukil <sailesh@cloudera.com>

Mime
View raw message