impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified
Date Thu, 05 May 2016 18:22:12 GMT
Dan Hecht has uploaded a new patch set (#2).

Change subject: IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified
......................................................................

IMPALA-3337: fix "Cancelled" warnings when LIMIT clause is specified

The cancelled status is propagated in scanner threads to cause them to
shut down once the limit has been satisified, but depending on the code
path and when abort_on_error=false, this internal status would sometimes
incorrectly end up in the error log. Fix this by factoring out the
abort_on_error handling code so that it's handled more consistently
across scanners. Parquet, RC, and Avro all suffered from this bug.

Testing: exhastive

Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6
---
M be/src/exec/base-sequence-scanner.cc
M be/src/exec/hdfs-parquet-scanner.cc
M be/src/exec/hdfs-rcfile-scanner.cc
M be/src/exec/hdfs-scanner.cc
M be/src/exec/hdfs-scanner.h
M be/src/exec/hdfs-text-scanner.cc
M tests/query_test/test_scanners.py
7 files changed, 45 insertions(+), 36 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/64/2964/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4a91a22608e346ca21a23ea66c855eae54bbced6
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message