impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add ninja support for faster incremental builds
Date Wed, 04 May 2016 16:41:33 GMT
Tim Armstrong has posted comments on this change.

Change subject: Add ninja support for faster incremental builds
......................................................................


Patch Set 6:

I had the same problem with muscle memory just typing make.You have to run "ninja <target>".
If you run "make" it will use whatever makefiles were left-over. I'm not sure we want to mess
around with aliasing make to something else.

Maybe I should add some cleanup logic to delete old make/ninja files in a follow-up?

-- 
To view, visit http://gerrit.cloudera.org:8080/2923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cea479615fe850c98d30110de043ecb6358dcda
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message