impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3375: Improve TopN performance with a trivial Compare object.
Date Tue, 03 May 2016 21:59:38 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object.
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/exec/topn-node.cc
File be/src/exec/topn-node.cc:

Line 77:       new priority_queue<Tuple*, vector<Tuple*>, ComparatorWrapper<TupleRowComparator>
>(
move that c'tor call to a separate line so you don't have to break it up


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/service/impala-server-callbacks.cc
File be/src/service/impala-server-callbacks.cc:

Line 282
yeah, that's a weird one


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 621:   struct QueryStateRecordComparator {
is this <=? in that case, better to call it QueryStateLessThan


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/util/tuple-row-compare.h
File be/src/util/tuple-row-compare.h:

Line 40: template <typename T>
maybe call this one Comparator as opposed to just T, to make it clear that it's T that's being
wrapped/that's doing the comparison


Line 115:   bool Less(TupleRow* lhs, TupleRow* rhs) const {
is 'Less' an stl standard? otherwise LessThan seems more typical (as in DCHECK_LT)


Line 157:   bool Equal(Tuple* x, Tuple* y) {
is anyone wrapping this


-- 
To view, visit http://gerrit.cloudera.org:8080/2936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message