impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-2686: Add breakpad crash handler to all daemons
Date Tue, 03 May 2016 16:21:17 GMT
Lars Volker has posted comments on this change.

Change subject: IMPALA-2686: Add breakpad crash handler to all daemons
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2028/12/tests/custom_cluster/test_breakpad.py
File tests/custom_cluster/test_breakpad.py:

Line 76:     time.sleep(1)
> just that it's timing sensitive. maybe if the system is overcommitted it co
We only rely on the minidump being written, which should not take that long. Writing a core
will happen afterwards, but we don't rely on that being completed. Process.restart() from
tests/common/impala_cluster.py::Process does the same, so I assume it is the way to go:

def restart(self):
  """Kills and restarts the process"""
  self.kill()
  # Wait for a bit so the ports will be released.
  sleep(1)
  self.start()


-- 
To view, visit http://gerrit.cloudera.org:8080/2028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6
Gerrit-PatchSet: 12
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Casey Ching <casey@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message