impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Enable BOOST_NO_EXCEPTIONS for codegened code
Date Tue, 03 May 2016 16:09:58 GMT
Hello Skye Wanderman-Milne, Dan Hecht,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/2909

to look at the new patch set (#6).

Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
......................................................................

Enable BOOST_NO_EXCEPTIONS for codegened code

BOOST_NO_EXCEPTIONS lets us provide an handler for errors instead of
having boost throw exceptions. This lets us crash the process in a
slightly nicer way and also greatly reduces the number of static
exception objects littering the cross-compiled IR module, which helps
with codegen time.

Also turn on colour diagnostics for cross-compiled clang (it's already
enabled for ASAN clang).

Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50
---
M be/CMakeLists.txt
M be/src/codegen/llvm-codegen.cc
2 files changed, 14 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/09/2909/6
-- 
To view, visit http://gerrit.cloudera.org:8080/2909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message