impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Strip global constructors and destructors from codegen module
Date Mon, 02 May 2016 21:52:53 GMT
Michael Ho has posted comments on this change.

Change subject: Strip global constructors and destructors from codegen module
......................................................................


Patch Set 4:

Sorry, based on your reply, I cannot tell if logging in LLVM will still work. Can you please
confirm ? I know we don't enable logging in LLVM by default but if we do, do we have to do
something extra now ?

-- 
To view, visit http://gerrit.cloudera.org:8080/2910
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f4f5e08e506ad3a9c27c684daeb3344bdaec8b6
Gerrit-PatchSet: 4
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: No

Mime
View raw message