impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r' if necessary
Date Mon, 02 May 2016 21:16:12 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: IMPALA-3468: fix FindFirstInstance() SSE code to look for '\r' if necessary
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2926/1/be/src/exec/delimited-text-parser.cc
File be/src/exec/delimited-text-parser.cc:

Line 210: num_tuple_delims
> how about having a num_tuple_delims_ field analogous to num_delims_ for con
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/2926
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I39508f39077940d2e7b0bef8e5f5603a301bb313
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message