impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Enable BOOST_NO_EXCEPTIONS for codegened code
Date Mon, 02 May 2016 20:49:47 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2909/2/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

Line 784:   LOG(FATAL) << "Cannot handle exceptions in codegen'd code " << e.what();
> We'd still get a lot of the benefit: before there were a bunch of global ex
Oh awesome, yea let's do it then.


-- 
To view, visit http://gerrit.cloudera.org:8080/2909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message