impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Add ninja support for faster incremental builds
Date Mon, 02 May 2016 20:43:53 GMT
Tim Armstrong has uploaded a new patch set (#2).

Change subject: Add ninja support for faster incremental builds
......................................................................

Add ninja support for faster incremental builds

Ninja resolves dependencies much faster, so if only a couple of files
are changed "ninja -j ${IMPALA_BUILD_THREADS} impalad" returns within a
second or two, while make can take tens of seconds to resolve all the
dependencies.

This requires ninja to be installed. It is widely available, e.g. in the
ninja-build package on Ubuntu.

Ninja can be enabled by passing "-ninja" to buildall.sh or
make_impala.sh. The same targets should work as with make.

The default Ninja status output is fairly terse. It can be customised
with an environment variable. E.g. I have

export NINJA_STATUS="[%u to run/%r running/%f finished] "

Also fixes a bug in make_impala.sh where invalid arguments were ignored.

Change-Id: I2cea479615fe850c98d30110de043ecb6358dcda
---
M bin/make_impala.sh
M buildall.sh
2 files changed, 32 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/23/2923/2
-- 
To view, visit http://gerrit.cloudera.org:8080/2923
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2cea479615fe850c98d30110de043ecb6358dcda
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message