impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <>
Subject [Impala-CR](cdh5-trunk) Enable BOOST_NO_EXCEPTIONS for codegened code
Date Mon, 02 May 2016 18:51:47 GMT
Tim Armstrong has posted comments on this change.

Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code

Patch Set 2:

File be/CMakeLists.txt:

Line 138: # BOOST_NO_EXCEPTIONS: we can't handle exceptions in codegen'd code.
> nit: put one more space before BOOST to line up with -W options
File be/src/exprs/

Line 778: namespace boost {
> Even though most (all?) exceptions come from scalar fn calls, I would put t
I moved it to . We don't need to cross-compile it so it seems better not to put it

Line 784:   LOG(FATAL) << "Cannot handle exceptions in codegen'd code " << e.what();
> It's kind of unfortunate that this precludes gracefully handling boost exce
The macro name is kind of misleading: one of the use cases is to use the handler to throw
a custom exception class rather than a boost exception.

So it might even make it easier to gracefully handle boost exceptions if we wanted to go down
that path.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: Skye Wanderman-Milne <>
Gerrit-Reviewer: Tim Armstrong <>
Gerrit-HasComments: Yes

View raw message