impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR] IMPALA-3375: Improve TopN performance with a trivial Compare object.
Date Mon, 02 May 2016 17:52:12 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare object.
......................................................................


Patch Set 1:

(1 comment)

I haven't done a full review (although I'm happy to if you need another reviewer) but I wanted
to point out this weirdness we introduced as a workaround in a previous patch.

http://gerrit.cloudera.org:8080/#/c/2918/1/be/src/util/tuple-row-compare.h
File be/src/util/tuple-row-compare.h:

Line 143: codegend_compare_fn_
We introduced a pointer indirection here in a different patch, so the wrapper class adds a
second layer of indirection to get to the actual function pointer. Maybe copy this pointer
into the wrapper class to get around that?


-- 
To view, visit http://gerrit.cloudera.org:8080/2918
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message