impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Skye Wanderman-Milne (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) Enable BOOST_NO_EXCEPTIONS for codegened code
Date Mon, 02 May 2016 17:44:43 GMT
Skye Wanderman-Milne has posted comments on this change.

Change subject: Enable BOOST_NO_EXCEPTIONS for codegened code
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/2909/2/be/CMakeLists.txt
File be/CMakeLists.txt:

Line 138: # BOOST_NO_EXCEPTIONS: we can't handle exceptions in codegen'd code.
nit: put one more space before BOOST to line up with -W options


http://gerrit.cloudera.org:8080/#/c/2909/2/be/src/exprs/scalar-fn-call.cc
File be/src/exprs/scalar-fn-call.cc:

Line 778: namespace boost {
Even though most (all?) exceptions come from scalar fn calls, I would put this somewhere more
general, like impala-ir.cc.


Line 784:   LOG(FATAL) << "Cannot handle exceptions in codegen'd code " << e.what();
It's kind of unfortunate that this precludes gracefully handling boost exceptions (seems like
we'd need to catch the exception somewhere to e.g. cancel the query). Maybe this is OK since
it's just for built-in functions that use boost though. Maybe get a third opinion on this?


-- 
To view, visit http://gerrit.cloudera.org:8080/2909
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaff17b502a752963346b3a2f17fc58d22e778d50
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Skye Wanderman-Milne <skye@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message