impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3458: Fix table creation to test insert with header lines
Date Sun, 01 May 2016 23:52:37 GMT
Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3458: Fix table creation to test insert with header lines
......................................................................


Patch Set 1:

(2 comments)

Thanks for investigating, just had a couple of quesitons.

http://gerrit.cloudera.org:8080/#/c/2919/1/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

Line 1897: CREATE TABLE IF NOT EXISTS {db_name}{db_suffix}.{table_name} (i1 integer)
Don't you need the tblproperties here?


http://gerrit.cloudera.org:8080/#/c/2919/1/testdata/datasets/functional/schema_constraints.csv
File testdata/datasets/functional/schema_constraints.csv:

Line 175: table_name:table_with_header_insert, constraint:restrict_to, table_format:text/none/none
Doesn't match the comment above, probably needs a separate comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/2919
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie68e7067b7a16218d27935820d5d1ce7035d2e6c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message