Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 153C019618 for ; Thu, 28 Apr 2016 16:14:28 +0000 (UTC) Received: (qmail 36994 invoked by uid 500); 28 Apr 2016 16:14:27 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 36954 invoked by uid 500); 28 Apr 2016 16:14:27 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 36943 invoked by uid 99); 28 Apr 2016 16:14:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 16:14:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DC3D1180233 for ; Thu, 28 Apr 2016 16:14:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 8H__yA5u-s9a for ; Thu, 28 Apr 2016 16:14:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 6BF855F23A for ; Thu, 28 Apr 2016 16:14:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3SGEMfn012131; Thu, 28 Apr 2016 16:14:22 GMT Message-Id: <201604281614.u3SGEMfn012131@ip-10-146-233-104.ec2.internal> Date: Thu, 28 Apr 2016 16:14:22 +0000 From: "Silvius Rus (Code Review)" To: Lars Volker , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Casey Ching , Tim Armstrong Reply-To: srus@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2686:_Add_breakpad_crash_handler_to_all_daemons=0A?= X-Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4ea84b7be28c9a6df83f189cde85762a18d3f80e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Silvius Rus has posted comments on this change. Change subject: IMPALA-2686: Add breakpad crash handler to all daemons ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/2028/11/be/src/util/minidump.cc File be/src/util/minidump.cc: Line 55: printf("Wrote minidump to %s\n", descriptor.path()); We should try our best not to trigger exceptions or signals from the handler. printf may allocate memory. Consider using write instead of printf. -- To view, visit http://gerrit.cloudera.org:8080/2028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a37a38488716ffe34296f3490ae291bbb7228d6 Gerrit-PatchSet: 11 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Silvius Rus Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes