Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A514A185CC for ; Sat, 23 Apr 2016 00:03:05 +0000 (UTC) Received: (qmail 50312 invoked by uid 500); 23 Apr 2016 00:03:05 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 50270 invoked by uid 500); 23 Apr 2016 00:03:05 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 50257 invoked by uid 99); 23 Apr 2016 00:03:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Apr 2016 00:03:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E8376C0DE6 for ; Sat, 23 Apr 2016 00:03:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ndRDdnRtvBUy for ; Sat, 23 Apr 2016 00:03:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 9C6EE5F23E for ; Sat, 23 Apr 2016 00:03:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3N031UE013914; Sat, 23 Apr 2016 00:03:01 GMT Message-Id: <201604230003.u3N031UE013914@ip-10-146-233-104.ec2.internal> Date: Sat, 23 Apr 2016 00:03:01 +0000 From: "Tim Armstrong (Code Review)" To: Alex Behm , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Mostafa Mokhtar , Skye Wanderman-Milne Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2736:_Basic_column-wise_slot_materialization_in_Parquet_scanner.=0A?= X-Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa X-Gerrit-ChangeURL: X-Gerrit-Commit: 6324408ff8771135d6e1c67028378fa3ed260558 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Tim Armstrong has posted comments on this change. Change subject: IMPALA-2736: Basic column-wise slot materialization in Parquet scanner. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2779/5/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 1842: // The output batch must have enough room at this point. > Good point. A while loop below seems much clearer, thanks for the suggestio This is nicer, thanks. -- To view, visit http://gerrit.cloudera.org:8080/2779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I72a613fa805c542e39df20588fb25c57b5f139aa Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Mostafa Mokhtar Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes