Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@impala.incubator.apache.org
Message-Id: <201604221901.u3MJ1fVb003460@ip-10-146-233-104.ec2.internal>
Date: Fri, 22 Apr 2016 19:01:41 +0000
From: "Michael Ho (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, dev@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>, Dan Hecht <dhecht@cloudera.com>,
        Tim Armstrong <tarmstrong@cloudera.com>
Reply-To: kwho@cloudera.com
Subject: 
 =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3350:_Add_some_missing_StringVal.is=5Fnull_checks=0A?=
In-Reply-To: 
 <gerrit.1460596462000.I55777487fff15a521818e39b4f93a8a242770ec2@gerrit.cloudera.org>
References: 
 <gerrit.1460596462000.I55777487fff15a521818e39b4f93a8a242770ec2@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.10-rc0

Michael Ho has posted comments on this change.

Change subject: IMPALA-3350: Add some missing StringVal.is_null checks
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/2786/3/be/src/udf/udf.cc
File be/src/udf/udf.cc:

Line 459:   if (UNLIKELY((unsigned)len > StringVal::MAX_LENGTH)) {
> maybe we should make StringVal::MAX_LENGTH unsigned so that comparisons wil
Good point. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/2786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55777487fff15a521818e39b4f93a8a242770ec2
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes