Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D53951971C for ; Thu, 21 Apr 2016 23:18:12 +0000 (UTC) Received: (qmail 8429 invoked by uid 500); 21 Apr 2016 23:18:12 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 8389 invoked by uid 500); 21 Apr 2016 23:18:12 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 8378 invoked by uid 99); 21 Apr 2016 23:18:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 23:18:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1DCF2180558 for ; Thu, 21 Apr 2016 23:18:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Z5lCwDE2x9zL for ; Thu, 21 Apr 2016 23:18:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 652D05FBB2 for ; Thu, 21 Apr 2016 23:18:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3LNI6Bv021076; Thu, 21 Apr 2016 23:18:06 GMT Message-Id: <201604212318.u3LNI6Bv021076@ip-10-146-233-104.ec2.internal> Date: Thu, 21 Apr 2016 23:18:06 +0000 From: "Juan Yu (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: jyu@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Fix_ConcurrentTimerCounter_unit_test_=22TimerCounterTest=22_failure.=0A?= X-Gerrit-Change-Id: I807a774da27ff6215f790ec44c9706fa6f95639f X-Gerrit-ChangeURL: X-Gerrit-Commit: 7bea71d5c90fbd77db981e855bcf9a91c749a568 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Juan Yu has posted comments on this change. Change subject: Fix ConcurrentTimerCounter unit test "TimerCounterTest" failure. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2838/2/be/src/util/runtime-profile-test.cc File be/src/util/runtime-profile-test.cc: Line 614: if (!(stopwatch_value >= expected_value - TimerCounterTest::MAX_TIMER_ERROR_NS && Log the timer error if it is larger than the TimerCounterTest::MAX_TIMER_ERROR_NS so if the test fails again we could check if it's in valid range or not. -- To view, visit http://gerrit.cloudera.org:8080/2838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I807a774da27ff6215f790ec44c9706fa6f95639f Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Juan Yu Gerrit-Reviewer: Juan Yu Gerrit-HasComments: Yes