Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1B59A19624 for ; Thu, 21 Apr 2016 18:36:40 +0000 (UTC) Received: (qmail 15715 invoked by uid 500); 21 Apr 2016 18:36:39 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 15674 invoked by uid 500); 21 Apr 2016 18:36:39 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 15663 invoked by uid 99); 21 Apr 2016 18:36:39 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 18:36:39 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 40886C24FD for ; Thu, 21 Apr 2016 18:36:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id iSo2cqHbe9G5 for ; Thu, 21 Apr 2016 18:36:37 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 1D9AC5F47B for ; Thu, 21 Apr 2016 18:36:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3LIaZAP012911; Thu, 21 Apr 2016 18:36:35 GMT Message-Id: <201604211836.u3LIaZAP012911@ip-10-146-233-104.ec2.internal> Date: Thu, 21 Apr 2016 18:36:35 +0000 From: "Skye Wanderman-Milne (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Bharath Vissapragada , Dimitris Tsirogiannis , Michael Ho Reply-To: skye@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3378/IMPALA-3379:_fix_various_JNI_issues=0A?= X-Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941 X-Gerrit-ChangeURL: X-Gerrit-Commit: 058eef7bf8fd9919ffaab8f400ffb5cace5e84c4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/2820/4/be/src/exprs/hive-udf-call.cc File be/src/exprs/hive-udf-call.cc: Line 203: if (env == NULL) return Status("Failed to get/create JVM"); > We will always call Close() even if Open() failed, right ? We should: https://github.com/cloudera/Impala/blob/cdh5-trunk/be/src/exprs/expr-context.cc#L43 -- To view, visit http://gerrit.cloudera.org:8080/2820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cd089e355d2ee2d5ace81f05b214272c05cf941 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-HasComments: Yes