Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0CB71957C for ; Thu, 21 Apr 2016 18:19:21 +0000 (UTC) Received: (qmail 72156 invoked by uid 500); 21 Apr 2016 18:19:21 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 72118 invoked by uid 500); 21 Apr 2016 18:19:21 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 72106 invoked by uid 99); 21 Apr 2016 18:19:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 18:19:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 60DF1180547 for ; Thu, 21 Apr 2016 18:19:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id NotfG81lpQZD for ; Thu, 21 Apr 2016 18:19:19 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id EB1AD5F1EB for ; Thu, 21 Apr 2016 18:19:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3LIJH32011833; Thu, 21 Apr 2016 18:19:17 GMT Message-Id: <201604211819.u3LIJH32011833@ip-10-146-233-104.ec2.internal> Date: Thu, 21 Apr 2016 18:19:17 +0000 From: "Alex Behm (Code Review)" To: Michael Brown , impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: alex.behm@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3329:_custom_cluster_tests:_set_-max=5Flog=5Ffiles_to_unlimited=0A?= X-Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9a62864c1fd2c2aca2136b3d8457139ec4cd4b2e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Alex Behm has posted comments on this change. Change subject: IMPALA-3329: custom cluster tests: set -max_log_files to unlimited ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2759/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: Line 28: DEFAULT_IMPALA_MAX_LOG_FILES = os.environ.get('IMPALA_MAX_LOG_FILES', 10) This new env variable seems oddly specific. We already have the ability to pass daemon startup flags via --impalad_args, etc. Why can't we use the existing mechanism? For example, we could populate those options by default in the maps IMPALAD_ARGS, STATESTORE_ARGS, CATALOGD_ARGS in CustomClusterTestSuite, or something along those lines. -- To view, visit http://gerrit.cloudera.org:8080/2759 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbb2a8616adcb0cd2fb838505117e0e9ba39083 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Michael Brown Gerrit-HasComments: Yes