Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E4D1019054 for ; Thu, 21 Apr 2016 02:35:37 +0000 (UTC) Received: (qmail 79797 invoked by uid 500); 21 Apr 2016 02:35:37 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 79753 invoked by uid 500); 21 Apr 2016 02:35:37 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 79742 invoked by uid 99); 21 Apr 2016 02:35:37 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Apr 2016 02:35:37 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 37FFBC0227 for ; Thu, 21 Apr 2016 02:35:37 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LS1xYYotBqiW for ; Thu, 21 Apr 2016 02:35:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id AD3B85F473 for ; Thu, 21 Apr 2016 02:35:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3L2ZWNP004497; Thu, 21 Apr 2016 02:35:32 GMT Message-Id: <201604210235.u3L2ZWNP004497@ip-10-146-233-104.ec2.internal> Date: Thu, 21 Apr 2016 02:35:32 +0000 From: "Dan Hecht (Code Review)" To: Huaisi Xu , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Bharath Vissapragada Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3385:_hold_locks_when_returning_error=5Flog=0A?= X-Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc X-Gerrit-ChangeURL: X-Gerrit-Commit: 831567dddc47c337cf79359f5689777dcbac54d1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: hold locks when returning error_log ...................................................................... Patch Set 1: > Yes I will try tomorrow. Dan could you say a little about why you > do not think so? the hdfs scan node path that crashes doesn't use this accessor. I think the error log logic is probably broken in multiple ways and we don't understand all the ways it's broken. We need to repro in order to be confident we're fixing, and to regression test. To repro, you could try adding a stress option that injects synthetic errors into queries. -- To view, visit http://gerrit.cloudera.org:8080/2829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a7e3d22e26147ada780aae5aed1f2e25a515afc Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Huaisi Xu Gerrit-HasComments: No