Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9093118121 for ; Wed, 20 Apr 2016 21:49:13 +0000 (UTC) Received: (qmail 79926 invoked by uid 500); 20 Apr 2016 21:49:13 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 79882 invoked by uid 500); 20 Apr 2016 21:49:13 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 79838 invoked by uid 99); 20 Apr 2016 21:49:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Apr 2016 21:49:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 9E72F1A05BC for ; Wed, 20 Apr 2016 21:49:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id AMJPiU_JmuCA for ; Wed, 20 Apr 2016 21:49:10 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id E8BA05FAE1 for ; Wed, 20 Apr 2016 21:49:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3KLnACC028118; Wed, 20 Apr 2016 21:49:10 GMT Message-Id: <201604202149.u3KLnACC028118@ip-10-146-233-104.ec2.internal> Date: Wed, 20 Apr 2016 21:49:09 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Casey Ching Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Source_query_files_from_shell.=0A?= X-Gerrit-Change-Id: Ib05df3e755cd12e9e9562de6b353857940eace03 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6997af78ee0fdde5b380d4cf1ea38d03178f2c31 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Henry Robinson has posted comments on this change. Change subject: Source query files from shell. ...................................................................... Patch Set 1: (2 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/2663/1/shell/impala_shell.py File shell/impala_shell.py: Line 1034: print_to_stderr("Error opening file '%s': %s" % (args, e)) > Reducing the scope of this try/except to just the open() call would be nice Done Line 1110: if not self.imp_client.connected: return False > Will the user see a message saying why the file wasn't executed? Done -- To view, visit http://gerrit.cloudera.org:8080/2663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05df3e755cd12e9e9562de6b353857940eace03 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Henry Robinson Gerrit-HasComments: Yes