Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 735E019B3D for ; Tue, 19 Apr 2016 23:56:05 +0000 (UTC) Received: (qmail 64136 invoked by uid 500); 19 Apr 2016 23:56:05 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 64093 invoked by uid 500); 19 Apr 2016 23:56:05 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 64070 invoked by uid 99); 19 Apr 2016 23:56:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 23:56:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 807B5C0224 for ; Tue, 19 Apr 2016 23:56:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id G_SnG_AidPCQ for ; Tue, 19 Apr 2016 23:56:01 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id DE9775F343 for ; Tue, 19 Apr 2016 23:56:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3JNtxVq006077; Tue, 19 Apr 2016 23:55:59 GMT Message-Id: <201604192355.u3JNtxVq006077@ip-10-146-233-104.ec2.internal> Date: Tue, 19 Apr 2016 23:55:57 +0000 From: "Taras Bobrovytsky (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm Reply-To: tbobrovytsky@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3155:_Disable_implicit_casting_of_CHAR_to_STRING_in_CASE_statements=0A?= X-Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8b49086cc446117ae7afd1fa020cd2dfb80acf55 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Taras Bobrovytsky has uploaded a new patch set (#4). Change subject: IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements ...................................................................... IMPALA-3155: Disable implicit casting of CHAR to STRING in CASE statements All CHAR children of a CASE expression were automaticallally implicitly cast to STRING. This commit removes this behavior for the THEN clause of a CASE statement, i.e., if all THEN exprs of a CASE expression are CHAR, then the type of the CASE expression will be CHAR. Change-Id: I4aebac6849898693570bc3164fff40786c215358 --- M fe/src/main/java/com/cloudera/impala/analysis/CaseExpr.java M fe/src/main/java/com/cloudera/impala/analysis/Expr.java M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeExprsTest.java 3 files changed, 21 insertions(+), 13 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/62/2762/4 -- To view, visit http://gerrit.cloudera.org:8080/2762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4aebac6849898693570bc3164fff40786c215358 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Taras Bobrovytsky