Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9D278195D9 for ; Tue, 19 Apr 2016 04:27:59 +0000 (UTC) Received: (qmail 20679 invoked by uid 500); 19 Apr 2016 04:27:59 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 20633 invoked by uid 500); 19 Apr 2016 04:27:59 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 20622 invoked by uid 99); 19 Apr 2016 04:27:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 04:27:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 19998C0D4D for ; Tue, 19 Apr 2016 04:27:58 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ks_UoSMNnr2p for ; Tue, 19 Apr 2016 04:27:56 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id ECD545F3F5 for ; Tue, 19 Apr 2016 04:27:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3J4Rspr018278; Tue, 19 Apr 2016 04:27:54 GMT Message-Id: <201604190427.u3J4Rspr018278@ip-10-146-233-104.ec2.internal> Date: Tue, 19 Apr 2016 04:27:54 +0000 From: "Internal Jenkins (Code Review)" To: Casey Ching , impala-cr@cloudera.com, dev@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Kudu:_Remove_post_merge_TODOs_that_need_no_real_work=0A?= X-Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 X-Gerrit-ChangeURL: X-Gerrit-Commit: 18377daa6e7d8a19efa0564c188ad5df61a8914d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Internal Jenkins has submitted this change and it was merged. Change subject: Kudu: Remove post merge TODOs that need no real work ...................................................................... Kudu: Remove post merge TODOs that need no real work Comments on files: 1) BinaryPredicate: The TODO was to create a more generic function but I couldn't find another place that needed something like this. 2) KuduTable: Addressed TOOD by adding comment to explain constant "-1". 3) UnsupportedOpDelegate: The TODO was to consider returning an error, I didn't see much benefit in doing that. 4) KuduScanNode: The TODO was to consider replacing a predicate with a literal "false", that's a fine suggestion but not particularly related to Kudu. It's just a general planner enhancement so I won't address that. Change-Id: I42c8120574def06727b645941bbf64cc69804120 Reviewed-on: http://gerrit.cloudera.org:8080/2807 Reviewed-by: Alex Behm Tested-by: Internal Jenkins --- M fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java M fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java M fe/src/main/java/com/cloudera/impala/catalog/delegates/UnsupportedOpDelegate.java M fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java 4 files changed, 1 insertion(+), 9 deletions(-) Approvals: Internal Jenkins: Verified Alex Behm: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Internal Jenkins