Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D83C18A8C for ; Mon, 18 Apr 2016 23:18:25 +0000 (UTC) Received: (qmail 61704 invoked by uid 500); 18 Apr 2016 23:18:25 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 61657 invoked by uid 500); 18 Apr 2016 23:18:25 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 61645 invoked by uid 99); 18 Apr 2016 23:18:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Apr 2016 23:18:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 503E7C0BC3 for ; Mon, 18 Apr 2016 23:18:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id EZHfZe4CBLho for ; Mon, 18 Apr 2016 23:18:22 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 993E65F23C for ; Mon, 18 Apr 2016 23:18:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3INILbH012334; Mon, 18 Apr 2016 23:18:21 GMT Message-Id: <201604182318.u3INILbH012334@ip-10-146-233-104.ec2.internal> Date: Mon, 18 Apr 2016 23:18:21 +0000 From: "Casey Ching (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm Reply-To: casey@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Kudu:_Remove_post_merge_TODOs_that_need_no_real_work=0A?= X-Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 X-Gerrit-ChangeURL: X-Gerrit-Commit: 92e45e585e8a80f3055f364f2a1241876fb6952e In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Casey Ching has posted comments on this change. Change subject: Kudu: Remove post merge TODOs that need no real work ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java File fe/src/main/java/com/cloudera/impala/analysis/BinaryPredicate.java: Line 118 > There is some similarity with SingleNodePlanner.getNormalizedEqPred(). It m Oh I saw that before but it didn't look similar enough. I'm going to leave it as-is. http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java File fe/src/main/java/com/cloudera/impala/catalog/KuduTable.java: Line 259: builder.add("-1"); // The API doesn't expose tablet row counts. > The Kudu Client API .... Done http://gerrit.cloudera.org:8080/#/c/2807/1/fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java File fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java: Line 272 > Imo removing this TODO is ok because I think we'd want to do this optimizat Done -- To view, visit http://gerrit.cloudera.org:8080/2807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c8120574def06727b645941bbf64cc69804120 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Casey Ching Gerrit-HasComments: Yes