Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 13ACD190C9 for ; Fri, 15 Apr 2016 22:14:41 +0000 (UTC) Received: (qmail 3395 invoked by uid 500); 15 Apr 2016 22:14:41 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 3347 invoked by uid 500); 15 Apr 2016 22:14:41 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 3336 invoked by uid 99); 15 Apr 2016 22:14:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 22:14:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5D8171A008F for ; Fri, 15 Apr 2016 22:14:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Th_IfBwGb_Th for ; Fri, 15 Apr 2016 22:14:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 583625F1E9 for ; Fri, 15 Apr 2016 22:14:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3FMEb3N014346; Fri, 15 Apr 2016 22:14:37 GMT Message-Id: <201604152214.u3FMEb3N014346@ip-10-146-233-104.ec2.internal> Date: Fri, 15 Apr 2016 22:14:37 +0000 From: "Matthew Jacobs (Code Review)" To: Thomas Tauber-Marshall , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Henry Robinson Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-2198:_Differentiate_queries_in_exceptional_states_in_web_UI=0A?= X-Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9cdab89818efd293eb2fb48cdbbf38cb9275d988 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-2198: Differentiate queries in exceptional states in web UI ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2625/3/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 610: all_rows_returned > FWIW I asked Thomas to change this from 'eos', which I think isn't quite as Ok, I don't feel strongly about it either way. all_rows_returned is clear. -- To view, visit http://gerrit.cloudera.org:8080/2625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d0b642ecb573fefbbf337b8c8f2c479b0d49b2 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes