Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08FAB196EA for ; Fri, 15 Apr 2016 01:03:34 +0000 (UTC) Received: (qmail 24610 invoked by uid 500); 15 Apr 2016 01:03:34 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 24570 invoked by uid 500); 15 Apr 2016 01:03:34 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 24559 invoked by uid 99); 15 Apr 2016 01:03:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Apr 2016 01:03:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CA3F11A11B0 for ; Fri, 15 Apr 2016 01:03:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id E5wdqQRiXvRX for ; Fri, 15 Apr 2016 01:03:31 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 556E45F1E7 for ; Fri, 15 Apr 2016 01:03:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3F13U1k030266; Fri, 15 Apr 2016 01:03:30 GMT Message-Id: <201604150103.u3F13U1k030266@ip-10-146-233-104.ec2.internal> Date: Fri, 15 Apr 2016 01:03:30 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Dan Hecht , Tim Armstrong Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3077:_Enable_runtime_filters_when_PHJ_spills=0A?= X-Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e X-Gerrit-ChangeURL: X-Gerrit-Commit: 3b18793a306f794d1bb857a76e135a8c58dff02d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Henry Robinson has posted comments on this change. Change subject: IMPALA-3077: Enable runtime filters when PHJ spills ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/2783/2/be/src/exec/partitioned-hash-join-node.cc File be/src/exec/partitioned-hash-join-node.cc: Line 1221: } > this code block no longer makes sense. also we loose this optimization so w Done. We can measure if there's any performance loss, but I'd expect it to be fairly small. IMPALA-3007 should make this case less frequent as well, which I'm also hoping to get into 2.6. Line 1620: // Never build filters after repartitioning > can you briefly explain the "why" as well (because we'll have already exami Done -- To view, visit http://gerrit.cloudera.org:8080/2783 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a2d9ee03ccea6b674392584e4c7f272233571e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes