Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BC90D1983F for ; Mon, 11 Apr 2016 21:41:13 +0000 (UTC) Received: (qmail 57487 invoked by uid 500); 11 Apr 2016 21:41:13 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 57450 invoked by uid 500); 11 Apr 2016 21:41:13 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 57435 invoked by uid 99); 11 Apr 2016 21:41:13 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 21:41:13 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E2FC1C0CF3 for ; Mon, 11 Apr 2016 21:41:12 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Pge6SWF9yrm7 for ; Mon, 11 Apr 2016 21:41:11 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 5EE525F20E for ; Mon, 11 Apr 2016 21:41:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u3BLf8sQ001580; Mon, 11 Apr 2016 21:41:08 GMT Message-Id: <201604112141.u3BLf8sQ001580@ip-10-146-233-104.ec2.internal> Date: Mon, 11 Apr 2016 21:41:08 +0000 From: "Skye Wanderman-Milne (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Tim Armstrong Reply-To: skye@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_Add_NumFunctions_and_NumInstructions_counters_to_LlvmCodeGen=0A?= X-Gerrit-Change-Id: I9a7f4aa02239d0738d891b09fa4531b560428898 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2c32329be0ca937f6ccc4e733c5341845f113bef In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Skye Wanderman-Milne has posted comments on this change. Change subject: Add NumFunctions and NumInstructions counters to LlvmCodeGen ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2756/1/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 735: // Update counters before final optimization > Expand comment to explain why we're doing this after DCE Done -- To view, visit http://gerrit.cloudera.org:8080/2756 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7f4aa02239d0738d891b09fa4531b560428898 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Skye Wanderman-Milne Gerrit-Reviewer: Skye Wanderman-Milne Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes