Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BC55180B9 for ; Wed, 6 Apr 2016 03:59:01 +0000 (UTC) Received: (qmail 27558 invoked by uid 500); 6 Apr 2016 03:59:01 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 27495 invoked by uid 500); 6 Apr 2016 03:59:01 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 27484 invoked by uid 99); 6 Apr 2016 03:59:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Apr 2016 03:59:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 1276BC0362 for ; Wed, 6 Apr 2016 03:59:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id pSVOMpHlUtQh for ; Wed, 6 Apr 2016 03:58:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 5A2545F217 for ; Wed, 6 Apr 2016 03:58:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u363wtRd029454; Wed, 6 Apr 2016 03:58:55 GMT Message-Id: <201604060358.u363wtRd029454@ip-10-146-233-104.ec2.internal> Date: Wed, 6 Apr 2016 03:58:55 +0000 From: "Casey Ching (Code Review)" To: Todd Lipcon , impala-cr@cloudera.com, dev@impala.incubator.apache.org CC: Alex Behm Reply-To: casey@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_IMPALA-3148._Fix_selectivity_computation_for_pushed_Kudu_predicates=0A?= X-Gerrit-Change-Id: Id507077b577ed5804fc80517f33ea185f2bff41a X-Gerrit-ChangeURL: X-Gerrit-Commit: 21b067a18bcf2fd6b2d267f2b1bc3d9debc3f279 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Casey Ching has uploaded a new patch set (#2). Change subject: IMPALA-3148. Fix selectivity computation for pushed Kudu predicates ...................................................................... IMPALA-3148. Fix selectivity computation for pushed Kudu predicates This follows up on a TODO from the Kudu merge and also fixes a bug: IMPALA-976 changed the computation of selectivities for a combined list of conjuncts to better handle expressions with no selectivity estimate. The Kudu implementation was forked from before this change and thus did not have an equivalent change. This refactors the algorithm to a new static method and calls it from both PlanNode and KuduScanNode so that the selectivity estimate behavior is the same regardless of whether Kudu can evaluate the predicate server-side. Todd tested this on TPCH 3TB and verified that the plans are reasonable now where they used to be nonsense. Change-Id: Id507077b577ed5804fc80517f33ea185f2bff41a --- M fe/src/main/java/com/cloudera/impala/planner/KuduScanNode.java M fe/src/main/java/com/cloudera/impala/planner/PlanNode.java M testdata/workloads/functional-planner/queries/PlannerTest/kudu-selectivity.test 3 files changed, 73 insertions(+), 16 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/28/2628/2 -- To view, visit http://gerrit.cloudera.org:8080/2628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id507077b577ed5804fc80517f33ea185f2bff41a Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Casey Ching Gerrit-Reviewer: Todd Lipcon