Return-Path: X-Original-To: apmail-impala-dev-archive@minotaur.apache.org Delivered-To: apmail-impala-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1DE8018B4F for ; Fri, 1 Apr 2016 01:19:19 +0000 (UTC) Received: (qmail 64840 invoked by uid 500); 1 Apr 2016 01:19:19 -0000 Delivered-To: apmail-impala-dev-archive@impala.apache.org Received: (qmail 64799 invoked by uid 500); 1 Apr 2016 01:19:19 -0000 Mailing-List: contact dev-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@impala.incubator.apache.org Delivered-To: mailing list dev@impala.incubator.apache.org Received: (qmail 64788 invoked by uid 99); 1 Apr 2016 01:19:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Apr 2016 01:19:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 537711A02BD for ; Fri, 1 Apr 2016 01:19:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id V8N14o917jJU for ; Fri, 1 Apr 2016 01:19:16 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with ESMTPS id 4CD715F24D for ; Fri, 1 Apr 2016 01:19:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id u311JEaY015438; Fri, 1 Apr 2016 01:19:14 GMT Message-Id: <201604010119.u311JEaY015438@ip-10-146-233-104.ec2.internal> Date: Fri, 1 Apr 2016 01:19:12 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, dev@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?[Impala-CR](cdh5-trunk)_PREVIEW_ONLY:_IMPALA-2737:_per-partition_processing_in_agg=0A?= X-Gerrit-Change-Id: I93adce55e6d9302dc191d95058440c8a9fa48f48 X-Gerrit-ChangeURL: X-Gerrit-Commit: 255a8f53160b2b7d0bca141c47e47c08d92b16a2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.10-rc0 Tim Armstrong has uploaded a new patch set (#4). Change subject: PREVIEW ONLY: IMPALA-2737: per-partition processing in agg ...................................................................... PREVIEW ONLY: IMPALA-2737: per-partition processing in agg Separates out evaluation of agg input rows from insertion into the hash table. This allows us to do a radix-sort of rows based on hash value and process a partition at a time. This sets things up to do optimisations like prefetching for aggregations and joins. TODO: update comments with changed IR TODO: improve performance - there is too much indirection with the different arrays in ExprValuesBuffer and PartitionedBatch. NOTE: this depends on the LLVM 3.8 patch Change-Id: I93adce55e6d9302dc191d95058440c8a9fa48f48 --- M be/src/codegen/gen_ir_descriptions.py M be/src/codegen/impala-ir.cc M be/src/exec/CMakeLists.txt A be/src/exec/hash-partitioning-ir.cc A be/src/exec/hash-partitioning.cc A be/src/exec/hash-partitioning.h M be/src/exec/hash-table-test.cc M be/src/exec/hash-table.cc M be/src/exec/hash-table.h M be/src/exec/hash-table.inline.h M be/src/exec/partitioned-aggregation-node-ir.cc M be/src/exec/partitioned-aggregation-node.cc M be/src/exec/partitioned-aggregation-node.h M be/src/exec/partitioned-hash-join-node.cc 14 files changed, 970 insertions(+), 349 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/91/2691/4 -- To view, visit http://gerrit.cloudera.org:8080/2691 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I93adce55e6d9302dc191d95058440c8a9fa48f48 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong