impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3412: codegen DCHECK with tuple comparator
Date Wed, 27 Apr 2016 00:40:29 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2876

Change subject: IMPALA-3412: codegen DCHECK with tuple comparator
......................................................................

IMPALA-3412: codegen DCHECK with tuple comparator

Attempting to codegen a sort where the sort expr has a CHAR type as an
intermediate result fails completely.

The problem is that ScalarFnCall checked whether its input arguments
were CHAR to disable codegen, but didn't check its output.

This patch also replaces some incorrect codegen CHAR logic that should
not be executed with DCHECKs.

Testing:
The test is a minimal reproduction of the issue. The test is executed
both by the sorter and top-n nodes so covers both cases.

Change-Id: I189073d46a10988803d572928a38f4a718690fa3
---
M be/src/codegen/codegen-anyval.cc
M be/src/exprs/scalar-fn-call.cc
M be/src/util/tuple-row-compare.cc
M testdata/workloads/functional-query/queries/QueryTest/top-n.test
4 files changed, 37 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/76/2876/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I189073d46a10988803d572928a38f4a718690fa3
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message