impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Armstrong (Code Review)" <ger...@cloudera.org>
Subject [Toolchain-CR] Disable terminfo dependency for LLVM
Date Mon, 25 Apr 2016 15:34:17 GMT
Tim Armstrong has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2860

Change subject: Disable terminfo dependency for LLVM
......................................................................

Disable terminfo dependency for LLVM

LLVM uses libtinfo/libncurses to detect whether a terminal supports
colors. This is used to support Clang's colourful error messages.
However, if this feature is turned on, the way the LLVM libraries
are factored we have to bring in this dependency regardless of whether
we're actually making use of output colouring.

We don't want to depend on these libraries if building an embedded JIT,
so let's just disable the feature. The downside of this change is that
we won't get colourful error messages from toolchain clang.

Also remove the LLVM trunk build script that has been slowly bitrotting.

Change-Id: I3e4fc73d4409592d55beb45a622e9f4a7deb5317
---
M source/llvm/build-source-tarball.sh
D source/llvm/build-trunk.sh
M source/llvm/build.sh
3 files changed, 2 insertions(+), 67 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/60/2860/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2860
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e4fc73d4409592d55beb45a622e9f4a7deb5317
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message