impala-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Ho (Code Review)" <ger...@cloudera.org>
Subject [Impala-CR](cdh5-trunk) IMPALA-3334: Fix some bugs in query options' parsing.
Date Wed, 13 Apr 2016 07:44:31 GMT
Michael Ho has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2776

Change subject: IMPALA-3334: Fix some bugs in query options' parsing.
......................................................................

IMPALA-3334: Fix some bugs in query options' parsing.

This change fixes two problems:

1. The query options OPTIMIZE_PARTITION_KEY_SCANS and
   DISABLE_STREAMING_PREAGGREGATIONS are both boolean
   so they should accept 'true' and '1' as input values.
   Previously, these two options are treated as int and
   value such as 'true' doesn't work with them.

2. The break statement in the case statement of the option
   SCAN_NODE_CODEGEN_THRESHOLD was 'stolen' by the option
   DISABLE_STREAMING_PREAGGREGATIONS when it was added.
   This change adds the missing break statement back for
   SCAN_NODE_CODEGEN_THRESHOLD.

Change-Id: I5c74a1e5c49e3bda15a91b40740fc7310303207b
---
M be/src/service/query-options.cc
M testdata/workloads/functional-query/queries/QueryTest/set.test
2 files changed, 96 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/76/2776/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c74a1e5c49e3bda15a91b40740fc7310303207b
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Michael Ho <kwho@cloudera.com>

Mime
View raw message